keyman
keyman copied to clipboard
refactor(android): merge keyboard-dimension setting JS calls into one
Fixes: #11734
User Testing
TEST_ROTATIONS: Ensure that the Android system keyboard rotates properly as the device orientation is changed.
TEST_RESTORE_FROM_BACKGROUND: Ensure that when the app is backgrounded and then restored, the keyboard is scaled properly.
User Test Results
Test specification and instructions
- ✅ TEST_ROTATIONS (PASSED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11828" build on the Android 14(Physical devices) and 11 & 12 simulator. Here is my observation. (notes)
- 🟥 TEST_RESTORE_FROM_BACKGROUND (FAILED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11828" build on the Android 13 & 14 Physical devices. Here is my observation. (notes)
Retesting Template
@keymanapp-test-bot retest TEST_RESTORE_FROM_BACKGROUND
Test Artifacts
Test Results
- TEST_ROTATIONS (PASSED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11828" build on the Android 14(Physical devices) and 11 & 12 simulator. Here is my observation.
- Installed the "Keyman-18.0.59.apk" file and gave all permissions to the application.
- Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
- Open the Keyman app. Enable the "Predictions" and install the "Dictionary"
- Enter some sentences in the text area.(Keyboard appears in portrait view)
- Rotate the mobile portrait to landscape view.
- Open any app in the landscape view.
- Rotate the mobile landscape to a portrait view.
- It works well. Thank you.
- TEST_RESTORE_FROM_BACKGROUND (FAILED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11828" build on the Android 13 & 14 Physical devices. Here is my observation.
- Installed the "Keyman-18.0.59.apk" file and gave all permissions to the application.
- Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
- Open the Keyman app. Enable the "Predictions" and install the "Dictionary"
- Enter some sentences in the text area.
- Open the Chrome browser and navigate to the "search" box.
- Click the returns button on the mobile.
- Rotate the mobile portrait to landscape view.
- Again, Open the Chrome browser and navigate to the "search" box.
- Click in the search box. Verify that the keyboard does not appear the first time.
- Close the "Keyman" app. Reopen the Keyman app.
- The keyboard appears correctly in landscape
- Rotate the mobile landscape to a portrait view.
- Rotate the mobile portrait to landscape view.
- Repeat these steps(Close the "Keyman" app. Reopen the Keyman app.)
- Here, Blank space appears above the keyboard or the keyboard size appears large.
Please refer to the screenshot below
As this hasn't been worked on in months, is not in my main area of expertise, and seems to have made things worse than they were, we're going to abandon this development path at this time. Can always try to revisit it later if need be, though.