keyman icon indicating copy to clipboard operation
keyman copied to clipboard

chore(mac): clean up code obsoleted by core

Open sgschantz opened this issue 1 year ago • 1 comments

Remove code that is no longer used because of the adoption of Keyman Core and design changes around it. Instead of several classes descending from KMInputMethodEventHandler to handle different degrees of compliance, we now use the class TextApiCompliance to repeatedly evaluate what the current state of compliance is. This is better because compliance can vary within the same application: for example, moving from the url search bar in Google Chrome to a Google Docs document in the content area, causes a change in compliance. When this happens, we do not want to switch event handlers because we are actually in the process of handling an event.

@keymanapp-test-bot skip

sgschantz avatar Feb 28 '24 06:02 sgschantz

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

keymanapp-test-bot[bot] avatar Feb 28 '24 06:02 keymanapp-test-bot[bot]

OK happy to go ahead on this.

mcdurdin avatar Mar 20 '24 01:03 mcdurdin

Changes in this pull request will be available for download in Keyman version 17.0.291-beta

keyman-server avatar Mar 20 '24 18:03 keyman-server