keyman icon indicating copy to clipboard operation
keyman copied to clipboard
verified publisher icon keymanapp

fix(linux): Replace deprecated `pkg_resources` module with `packaging.version`

Open ermshiperete opened this issue 1 year ago • 4 comments

Fixes #10850.

User Testing

Preparations

  • The tests should be run on these Linux platforms:

    • GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
    • GROUP_JAMMY: Ubuntu 22.04 Jammy with Gnome Shell and X11 or Wayland
    • GROUP_NOBLE: Ubuntu 24.04 Noble with Gnome Shell and X11 or Wayland

  • Install build artifacts of this PR

  • Reboot

Tests

TEST_NO_WARNING:

  • run km-package-install --version
  • verify that the version is output, but no warning

ermshiperete avatar Feb 27 '24 16:02 ermshiperete

User Test Results

Test specification and instructions

  • ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

    1 tests PASSED
    • ✅ TEST_NO_WARNING (PASSED): Tested with the attached PR build on Ubuntu 20.04 Focal Linux OS (VM) and here is my observation: 1. Run km-package-install --version on the terminal and verified that it is showing the version as output without showing any warning message. (notes)

  • ✅ GROUP_JAMMY: Ubuntu 22.04 Jammy with Gnome Shell and X11 or Wayland

    1 tests PASSED
    • ✅ TEST_NO_WARNING (PASSED): Tested with the attached PR build (17.0.277-beta (package version 17..277-1~PR-10860-2445.1+jammy1) on Ubuntu 22.004 Jammy Linux OS (X11) (Virtual Box) and here is my observation: 1. It is showing the version number without any warning message after running the above command. (notes)

  • ✅ GROUP_NOBLE: Ubuntu 24.04 Noble with Gnome Shell and X11 or Wayland

    1 tests PASSED
    • ✅ TEST_NO_WARNING (PASSED): ):

Test Artifacts

keymanapp-test-bot[bot] avatar Feb 27 '24 16:02 keymanapp-test-bot[bot]

Test Results

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

  • TEST_NO_WARNING (PASSED): Tested with the attached PR build on Ubuntu 20.04 Focal Linux OS (VM) and here is my observation: 1. Run km-package-install --version on the terminal and verified that it is showing the version as output without showing any warning message.

bharanidharanj avatar Mar 01 '24 11:03 bharanidharanj

Test Results

GROUP_NOBLE: Ubuntu 24.04 Noble with Gnome Shell and X11 or Wayland

  • TEST_NO_WARNING (FAILED): Tested with the attached PR build on Ubuntu 24.04 Noble Linux OS (wayland) (VM) and here is my observation: 1. Run km-package-install --version on the terminal and verified that it is showing the version with a warning message. Seems to be an issue.

bharanidharanj avatar Mar 01 '24 11:03 bharanidharanj

Test Results

GROUP_JAMMY: Ubuntu 22.04 Jammy with Gnome Shell and X11 or Wayland

  • TEST_NO_WARNING (PASSED): Tested with the attached PR build (17.0.277-beta (package version 17..277-1~PR-10860-2445.1+jammy1) on Ubuntu 22.004 Jammy Linux OS (X11) (Virtual Box) and here is my observation: 1. It is showing the version number without any warning message after running the above command.

bharanidharanj avatar Mar 04 '24 09:03 bharanidharanj

GROUP_NOBLE:

  • TEST_NO_WARNING (PASSED):

ermshiperete avatar Mar 20 '24 14:03 ermshiperete

Changes in this pull request will be available for download in Keyman version 17.0.291-beta

keyman-server avatar Mar 20 '24 18:03 keyman-server