feat(windows): insthelper Delphi to C++ conversion

[chenjieen]

Fixes: #8700 This creates a new C++ project to create a DLL to replace the current Delphi insthelper DLL.

[keymanapp-test-bot[bot]]

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

[mcdurdin]

I will review this on my return from leave in January

[rc-swag]

@chenjieen From a quick slack chat with Marc re logging. logging for that particular project should be to msi logs. https://resources.flexera.com/web/pdf/archive/msi_writing_to_the_log_file.pdf (really, pdf...) shows something like this:

// standard MSI DLL custom action signature
UINT __stdcall LoggingTestCpp(MSIHANDLE hInstall)
{
PMSIHANDLE hRecord = MsiCreateRecord(1);
// field 0 is the template
 MsiRecordSetString(hRecord, 0, "Log: [1]");
// field 1, to be placed in [1] placeholder
MsiRecordSetString(hRecord, 1, "Calling LoggingTestCpp...");
// send message to running installer
MsiProcessMessage(hInstall, INSTALLMESSAGE_INFO, hRecord);
return ERROR_SUCCESS;
} 

[keyman-server]

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

[mcdurdin]

@rc-swag, @chenjieen what is the status of this PR?

[rc-swag]

@mcdurdin. @chenjieen has addressed the review comments ready for a re-review except noting he could not get it to compile anymore. It has been sitting on my todo list as I was not quickly able to determin the issue. I may need your input. Or at least longer time to determine why needs to be changed.

[mcdurdin]

@rc-swag, do you have time to get this over the line or should we abandon it?

[mcdurdin]

We're going to abandon this for now. We don't have the capacity to continue on the Delphi -> C++ conversion internally. This code will still be here if anyone wants to pick it up and finish it.