GradientCircularProgress icon indicating copy to clipboard operation
GradientCircularProgress copied to clipboard

iOS 12 issues with Xcode10

Open southfox opened this issue 7 years ago • 1 comments

Hi guys,

awesome repository, we are using this for our application, thanks for sharing this.

I've been trying to build for iOS 12 under Xcode 10 and I'm having the following issues:

  • [ ] = #39 which is reported here
  • [ ] = Type 'UIWindow.Level' (aka 'CGFloat') has no member 'alert'
 //  BaseWindow.swift
...
       backgroundColor = UIColor.clear
        windowLevel = UIWindow.Level.alert + 1
        
        makeKey()

// CircularProgressView.swift

  • [ ] = 'didEnterBackgroundNotification' has been renamed to 'NSNotification.Name.UIApplicationDidEnterBackground'
        NotificationCenter.default.addObserver(self,
                                               selector: #selector(viewDidEnterBackground(_:)),
                                               name: UIApplication.didEnterBackgroundNotification,
                                               object: nil)
  • [ ] = 'willEnterForegroundNotification' has been renamed to 'NSNotification.Name.UIApplicationWillEnterForeground'
//  CircularProgressView.swift
        NotificationCenter.default.addObserver(self,
                                               selector: #selector(viewWillEnterForeground(_:)),
                                               name: UIApplication.willEnterForegroundNotification,
                                               object: nil)

Do you want me to send a PR for these issues? Thanks again.

southfox avatar Sep 26 '18 12:09 southfox

Hi, I've just publish a PR here to fix issue #39 and issue #40, could you review? Thanks.

southfox avatar Sep 26 '18 15:09 southfox