Kevin Rushforth
Kevin Rushforth
When this is ready for review, it will need plenty of testing. Since it is a behavioral change (albeit to fix a bug), we might consider whether it needs a...
I tend to think John is right and that the current behavior of ScrollPane is a bug. In general, dropping a control into a ScrollPane shouldn't change aspects of the...
We'll want extra pairs of eyes on this one (so at least two "R"eviewers). I'd also like Gluon to verify that it builds on their CI system. Reviewers: @kevinrushforth @prrace...
@azvegint When you do take it out of Draft, please write up something in the Description about the changes as a help to those who will be reviewing it. Also,...
The code changes all look good. I've done a fair bit of testing already, and will finish up my testing tomorrow.
This PR presupposes that the scroll bar size and content padding _should_ be changed to be independent of the font size. Since the current choice was a deliberate decision, the...
@andy-goryachev-oracle Wait for me to review this.
> > This PR presupposes that the scroll bar size and content padding _should_ be changed to be independent of the font size > > I disagree. The size of...
> It does not look right either, the UI elements should not get scaled in my opinion, only the text. I'd rather have a consistent size of UI elements in...
Can you turn the test case from the bug report into an automated test? /reviewers 2