Standard
- Use laravel/pint for code style fixes
- Drop support PHP 8.2 below (see php 8.1 will soon end of life https://php.watch/versions)
- Use Pest for testing
- Use phpstan for static analysis (max rule level 10)
- Add github actions
- Replace travis with github action workflow
hi @kevinkhill! hope you review this, thank you
Oh wow, you really overhauled everything. I am interested to see what you did. I'll try and take a look sometime soon. Thank you! 🙏
On Sat, Apr 26, 2025, 8:21 AM Lloric Mayuga Garcia @.***> wrote:
lloricode left a comment (kevinkhill/php-duration#29) https://github.com/kevinkhill/php-duration/pull/29#issuecomment-2832314401
hi @kevinkhill https://github.com/kevinkhill! hope you review this, thank you
— Reply to this email directly, view it on GitHub https://github.com/kevinkhill/php-duration/pull/29#issuecomment-2832314401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACA6XGXKMXAUUKKA4JHZQL23OQA7AVCNFSM6AAAAAB35PCY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZSGMYTINBQGE . You are receiving this because you were mentioned.Message ID: @.***>
been tested on production, and it is great
Hi @kevinkhill, it is been used this in production and working as expected, can you review it now? thank you
Hi there, so... Seeing how I'm probably never going to find time to do this... You will probably be better off forking it for your own purposes.
understood, let this PR open, so others will see
on my end it is working as expected, since this PR we already use it on our production