php-duration icon indicating copy to clipboard operation
php-duration copied to clipboard

Standard

Open lloricode opened this issue 2 years ago • 7 comments

  • Use laravel/pint for code style fixes
  • Drop support PHP 8.2 below (see php 8.1 will soon end of life https://php.watch/versions)
  • Use Pest for testing
  • Use phpstan for static analysis (max rule level 10)
  • Add github actions
  • Replace travis with github action workflow

lloricode avatar Nov 03 '23 07:11 lloricode

hi @kevinkhill! hope you review this, thank you

lloricode avatar Apr 26 '25 15:04 lloricode

Oh wow, you really overhauled everything. I am interested to see what you did. I'll try and take a look sometime soon. Thank you! 🙏

On Sat, Apr 26, 2025, 8:21 AM Lloric Mayuga Garcia @.***> wrote:

lloricode left a comment (kevinkhill/php-duration#29) https://github.com/kevinkhill/php-duration/pull/29#issuecomment-2832314401

hi @kevinkhill https://github.com/kevinkhill! hope you review this, thank you

— Reply to this email directly, view it on GitHub https://github.com/kevinkhill/php-duration/pull/29#issuecomment-2832314401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACA6XGXKMXAUUKKA4JHZQL23OQA7AVCNFSM6AAAAAB35PCY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZSGMYTINBQGE . You are receiving this because you were mentioned.Message ID: @.***>

kevinkhill avatar Apr 26 '25 15:04 kevinkhill

been tested on production, and it is great

lloricode avatar Apr 28 '25 04:04 lloricode

Hi @kevinkhill, it is been used this in production and working as expected, can you review it now? thank you

lloricode avatar Jun 08 '25 00:06 lloricode

Hi there, so... Seeing how I'm probably never going to find time to do this... You will probably be better off forking it for your own purposes.

kevinkhill avatar Oct 02 '25 14:10 kevinkhill

understood, let this PR open, so others will see

lloricode avatar Oct 03 '25 04:10 lloricode

on my end it is working as expected, since this PR we already use it on our production

lloricode avatar Oct 03 '25 04:10 lloricode