Yaniv Kessler

this.address which is heavily used in gossiper.js and peer_state.js is never assigned!

2

omg! this is why I kept getting peers with no ip address attached to them. stuff was still working since the connect code still referenced ip_to_bind, which was assigned...

In a situation like this: index.js ``` javascript var darkmagic = require('darkmagic') darkmagic.inject(function(y, callback) { callback() }) ``` y.js ``` javascript module.exports = function($injector, callback) { console.log('y') $injector.inject(function (z) {...

A bunch of insights I had so far from experimenting with darkmagic: 1. Async modules are fun, they make life easy 2. Being able to selectively replace dependencies makes writing...

``` module.exports = function (callback) { callback() callback() // should throw an error } ```

``` > var darkmagic = require('darkmagic') undefined > darkmagic.inject(function(mvc) { }) TypeError: Cannot read property 'filename' of undefined at Injector._initSearchPaths (/Users/kessler/dev/ironsrc/premium/bitfort/nwapp/node_modules/darkmagic/lib/Injector.js:244:41) at new Injector (/Users/kessler/dev/ironsrc/premium/bitfort/nwapp/node_modules/darkmagic/lib/Injector.js:22:7) at newInjector (/Users/kessler/dev/ironsrc/premium/bitfort/nwapp/node_modules/darkmagic/index.js:23:17) at Object.inject...

Would love to get some help on further optimizing the code.

structuredClone is not support across all platforms, so maybe it's best to upgrade the major version.