demix-data icon indicating copy to clipboard operation
demix-data copied to clipboard

Some code confused me.

Open run1999 opened this issue 3 years ago • 0 comments

Please check your code.

domains/s2orc/extract_papers.py

8 from joblib import Parallel, delayed Does this Parallel module work in your code?

29 if len(papers) > 512: I think it should be ‘==’ but not ‘>‘ , cause your shell script batch size is 512 , but your code create 513 files instead.

52 return metadata Is this 'metadata' declared in the function?

By the way, I don't see your "get_metadata" used in the main function.

run1999 avatar Sep 01 '22 11:09 run1999