Keri Moyle

Results 32 comments of Keri Moyle

Make sure that whatever is done by our new `create()` methods is also done by our bindings

I think all we need to do is to add the defaults to all of the construct/create methods: - the default constructor in C++ (which is available in Python/others) -...

Make sure that whatever is done by our new `create()` methods is also done by our bindings

See also https://github.com/cellml/libcellml/issues/600

Make sure that whatever is done by our new `create()` methods is also done by our bindings

This can be closed now ... the create overload is back (not sure when or how though!).

Issue class: Bindings and C++ behaviour is no longer consistent

The original intention behind using a tuple/pair everywhere was to make sure that we didn't end up with orphaned `std::any` items that we don't know the type for. We've lost...

Importer needs to track when ImportSource URL has changed after resolution

Reopening as we only have a temporary fix at present.

Change to when tabs are shown

This is "valid" too, we don't care about anything other than the tag names, and matching them up. ```xml A elephant C B ```

Importer: Giving an absolute path as URL should prevent adding baseFile

Yep, same underlying issue. I knew there was another one out there, thanks :)

Converter to LaTeX

I guess it depends whether the maths for publication should reflect the CellML model structure or the overall mathematical model structure? If the former, then the Generator is not ideal...

Default profile for generator differs?

Hmmm... OK. Not sure when that happened? I guess I'll change the tutorials again then :|

Default profile for generator differs?

Yes, but I'd thought it was a bug that was fixed: see https://github.com/cellml/libcellml/issues/508