lifecycle-toolkit icon indicating copy to clipboard operation
lifecycle-toolkit copied to clipboard

Explain that part-of and name annotations are concatenated

Open StackScribe opened this issue 1 year ago • 2 comments

Summary

The response to https://cloud-native.slack.com/archives/C017GAX90GM/p1715855191882149 expands on the following information from the Basic annotations:

  • If only the workload and version annotations/labels are available (in other words, neither the keptn.sh/app or app.kubernetes.io/part-of annotation/label is populated), Keptn creates a KeptnApp resource for each KeptnWorkload and your observability output traces the individual Keptnworkload resources but not the combined workloads that constitute your deployed application.

And on the architectural information in How basic annotations are implemented.

DoD

Update Basic annotations and/or How basic annotations are implemented to include text such as the following:

Note: Keptn application discovery concatenates the values of the app.kubernetes.io/name or keptn.sh/workload and app.kubernetes.io/part-of or keptn.sh/app annotation to determine the name of the KeptnWorkload. It does this by concatenating these two values:

Insert the note here

StackScribe avatar May 28 '24 06:05 StackScribe

@StackScribe I would like to work on this issue, can you please assign it to me.

shardulsrivastava avatar Jul 27 '24 10:07 shardulsrivastava

sure @shardulsrivastava ! I also updated the ticket description a little bit.

mowies avatar Jul 29 '24 06:07 mowies

This issue will be unassigned in 1 week if no further activity is seen. If you are active please provide an update on the status of the issue and if you would like to continue working on it.

github-actions[bot] avatar Oct 10 '24 12:10 github-actions[bot]

un-assigning, due to inactivity

mowies avatar Oct 10 '24 12:10 mowies

@mowies I would like to work on this issue

Garvit-77 avatar Oct 23 '24 05:10 Garvit-77

sure thing!

mowies avatar Oct 23 '24 06:10 mowies