lifecycle-toolkit icon indicating copy to clipboard operation
lifecycle-toolkit copied to clipboard

docs: introduce blogpost of ArgoCD and Keptn integration

Open odubajDT opened this issue 1 year ago • 3 comments

odubajDT avatar May 15 '24 09:05 odubajDT

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.33%. Comparing base (e044b51) to head (6df8642).

:exclamation: Current head 6df8642 differs from pull request most recent head 45ea026

Please upload reports for the commit 45ea026 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   85.38%   85.33%   -0.06%     
==========================================
  Files         167      167              
  Lines        7412     7412              
==========================================
- Hits         6329     6325       -4     
- Misses        796      799       +3     
- Partials      287      288       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (-0.33%) :arrow_down:
lifecycle-operator 83.46% <ø> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 16 '24 07:05 codecov[bot]

Very nicely done! I left a few minor suggestions for your consideration

Thank you for your review :)

odubajDT avatar May 21 '24 11:05 odubajDT

Should this PR have at least a bit of a description, to set a good example for other contributors if nothing else. It might also be nice if it linked to https://github.com/keptn/lifecycle-toolkit/issues/3356 just so that issue has a comprehensive list of the work that's been done.

StackScribe avatar May 23 '24 04:05 StackScribe