lifecycle-toolkit icon indicating copy to clipboard operation
lifecycle-toolkit copied to clipboard

KeptnTask defaults not provided

Open agardnerIT opened this issue 2 years ago • 6 comments

The KeptnTaskDefinition spec shows retries and timeout parameters but doesn't list the defaults.

https://lifecycle.keptn.sh/docs/crd-ref/lifecycle/v1alpha3/#keptntaskdefinitionspec

agardnerIT avatar Aug 10 '23 05:08 agardnerIT

Running a task without specifying retries or timeout I see:

apiVersion: lifecycle.keptn.sh/v1alpha3
kind: KeptnTask
metadata:
spec:
  ...
  retries: 10
  ...
  timeout: 5m0s
  ...

agardnerIT avatar Aug 10 '23 05:08 agardnerIT

The crd-ref-docs tool does not support this, however, if this is merged we could add the info as an annotation to kubebuilder to make it visible in the docs.

In the meantime, we could also add such info in the description field 🤔

RealAnna avatar Aug 11 '23 10:08 RealAnna

I'll put the label on hold since we depend on the external tool to provide this functionality

thisthat avatar Aug 16 '23 10:08 thisthat

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 16 '23 03:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 24 '23 03:12 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 23 '24 03:02 github-actions[bot]