kenshoo
Issue #149 - It is possible to select more than maxSelectedItems when
@talyak I've been having a hard time getting to this PR. Any chance you'd be willing to take a look?
@yegor-babiy - why not to change the following function like this:
export const getMinMaxIndexes = ( currentIndex, firstItemShiftSelected, maxSelectedItems ) => { const range = Math.abs(firstItemShiftSelected - currentIndex) + 1; if (range > maxSelectedItems) { return firstItemShiftSelected > currentIndex ? { minIndex: firstItemShiftSelected - maxSelectedItems + 1, maxIndex: firstItemShiftSelected } : { minIndex: firstItemShiftSelected, maxIndex: firstItemShiftSelected + maxSelectedItems - 1 }; } return firstItemShiftSelected > currentIndex ? { minIndex: currentIndex, maxIndex: firstItemShiftSelected } : { minIndex: firstItemShiftSelected, maxIndex: currentIndex }; };
@talyak first of all codeclimate will say that it's too complicated function with more than 5 operations and about logic in this case you don't count selected items that was selected outside range before
@liorheber @talyak guess it can be merged, I made all your recommendation