kenjis
kenjis
Ref https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6551
@MGatner This PR drops the dependency on interfaces, but methods can be added to interfaces. However, it may not be healthy to add more methods to the interface. Fat interfaces...
We defined interfaces, but our classes does not depend on the interfaces correctly. That is if a dev creates a class that implements the interface, there is no guarantee that...
I created this PR, because it seems we have a rule that we change our Interfaces only in major version up.
I sent a PR to fix ValidationInterface with the alternate approach of expanding interfaces to cover the actual method dependencies. See #6253
If we can change the ValidationInterface, we have an option to change it instead.
> there are probably more developers extending Model::__construct() than making their own Validation driver I agree. I guess so. It seems changing ValidationInterface makes less apps break.
I sent another PR #6253
#6253 was merged.
Something like these? `permit_empty[null]` `permit_empty[array,string,null,false]` === `permit_empty`