CGKB icon indicating copy to clipboard operation
CGKB copied to clipboard

use ENV vars for configuration

Open marsch opened this issue 8 years ago • 1 comments

As i tried the cgkb branch of avia (great article by the way) i had a hard time to figure out how that neo4j part was working, since cgkb was just a dependency in the package.json. From my understanding and experience it makes much more sense to put the configuration vars for db.json as an environment variable so it can be configured via deployment tools etc.

are u open for PRs here?

marsch avatar Mar 11 '17 21:03 marsch

Yep, open for PR :)

Do you mean exposing the ENV to the shell environment? Otherwise, the envs are already exposed within the node process; relevant AIVA code here; basically the JSONs in config are read and then set into process.env

kengz avatar Mar 13 '17 03:03 kengz