angular-validator icon indicating copy to clipboard operation
angular-validator copied to clipboard

TypeError: undefined is not a function - element[0].select()

Open cougar2010 opened this issue 11 years ago • 2 comments

In line 67 in directive.coffee element[0].select() will be returned which seems to be undefined in case of an validation error.

Console output:

TypeError: undefined is not a function
    at Object.angular.module.directive.link.rule.validator.error (angular-validator.js:63)
    at angular-validator.js:402
    at deferred.promise.then.wrappedCallback (angular.js:11682)

I think this can easily be fixed with try catch or undefined check.

cougar2010 avatar Mar 24 '15 09:03 cougar2010

After a bit debugging it seems this issue only occurs if you use the validation directives not directly on a input html element. I have a custom directive for input fields (including label, input elements and some other stuff) and I'm using the validation directive on my directive instead of the input field.

Supporting this could be achieved by something like this:

try {
    return element[0].select ? element[0].select() : element.find('input')[0].select();
} catch(_error) {
    console.warn('Error trying to select element ', _error.message, element);
}

cougar2010 avatar Mar 24 '15 09:03 cougar2010

Thanks @cougar2010
Had a little bug in your code. Fixed it for my case. I'm using the selectize control

try {
    return element[0].select ? element[0].select() : element.parent().children().find('input')[0].select();
} 
catch (_error)  {
    console.warn('Error trying to select element ', _error.message, element);
}

CarbonFactory avatar Aug 29 '15 17:08 CarbonFactory