buildifier-prebuilt icon indicating copy to clipboard operation
buildifier-prebuilt copied to clipboard

Add buildifier_test

Open erikkerber opened this issue 3 years ago • 1 comments

The rule here has diverged a bit from buildtools, namely that buildtools wraps the "diff" mode in a test rule useful for CI checks

https://github.com/bazelbuild/buildtools/blob/master/buildifier/buildifier.bzl#L37-L41

I was going to adopt this prebuilt strategy and clean up our WORKSPACE a bit, but hit a snag in that small difference.

Checking here if matching the rules in the buildtools source is a goal, and if so I'll open a patch.

erikkerber avatar Aug 29 '22 14:08 erikkerber

Yea I think having similar rules to that repo would be good. I can't recall but I think I omitted that one since it doesn't seem super common to use these days because of the inability to glob files.

keith avatar Aug 29 '22 15:08 keith

Included in 5.1.0.1, thanks!

keith avatar Nov 01 '22 21:11 keith