instance-manager icon indicating copy to clipboard operation
instance-manager copied to clipboard

MaxRetries: counter is reset on every resource submission

Open eytan-avisror opened this issue 4 years ago • 0 comments

https://github.com/keikoproj/instance-manager/blob/c0eb25d65856ca1261f70465c56950f4bfc0cdc3/controllers/providers/kubernetes/crd.go#L148-L156

The above logic states - if there is an error in creating a resource, and it already exists - do nothing, or fail if otherwise. If creation is successful - reset the maxRetry counter, this is problematic in the cases where the creation is due to replacement of a failed CR, causing an infinite retry scenario, which is not the intention.

We should evaluate not resetting the counter there and test out various concurrency policies with it.

eytan-avisror avatar Jun 28 '21 22:06 eytan-avisror