binary-parser icon indicating copy to clipboard operation
binary-parser copied to clipboard

Update @Ericbla encoder fork

Open stereokai opened this issue 2 years ago • 15 comments

Hi @keichi, I forked @Ericbla's binary-parser-encoder from #73 and updated it by cherry picking all the commits from this repo that were missing there. I also got all current tests passing both for the parser and the encoder.

Your binary-parser has the most developer friendly syntax out there in my opinion and it deserves an encoder to go along with it, and many users have also been showing interest in one. I'll be happy to commit for a little while to ensure this feature is implemented according to what you think is best for you and for the project.

Please let me know if you'd like to collaborate on this :)

stereokai avatar Aug 26 '23 10:08 stereokai

Any word on this getting merged? Seems like a lot of people were looking forward to this feature...

JeffBusch avatar Dec 13 '23 21:12 JeffBusch

Any word on this getting merged? Seems like a lot of people were looking forward to this feature...

They were looking for new mantainers after all.. I wouldn't pressure the mantainer lest we have the same thing like xz lmao, but I'm going to quietly use this fork instead

@stereokai not sure if this is much to ask, but can you write examples on how to use? (the encoding part)

Kreijstal avatar Apr 07 '24 18:04 Kreijstal

Any thoughts on this? I think a lot of people like to use only one package instead of 2 =) @keichi @yuhr

axi92 avatar May 22 '24 13:05 axi92

@Kreijstal check out the encoder tests in this PR which were written by the original encoder developer, @Ericbla, it's very simple and straightforward, you define a parser as usual and then just call .encode(plainOldJsObject)

stereokai avatar May 23 '24 09:05 stereokai

@Kreijstal check out the encoder tests in this PR which were written by the original encoder developer, @Ericbla, it's very simple and straightforward, you define a parser as usual and then just call .encode(plainOldJsObject)

Ahh, thank you that was so simple...

Kreijstal avatar May 23 '24 10:05 Kreijstal