keep icon indicating copy to clipboard operation
keep copied to clipboard
verified publisher icon keephq

fix: validate incident_id is UUID

Open amritansh22 opened this issue 1 year ago • 3 comments

Closes #2057

📑 Description

incident_id is of type UUID. When it is passed a string it causes an Internal Server Error. To avoid this have added a validation of the input param. Now the error returned will be 422.

Screenshot 2024-10-03 at 9 30 31 AM

✅ Checks

  • [x] My pull request adheres to the code style of this project
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • [x] All the tests have passed

ℹ Additional Information

amritansh22 avatar Oct 03 '24 04:10 amritansh22

@amritansh22 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 03 '24 04:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 03 '24 04:10 CLAassistant

Hey @shahargl Can you please review this PR ?

amritansh22 avatar Oct 04 '24 03:10 amritansh22

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:21am

vercel[bot] avatar Oct 07 '24 07:10 vercel[bot]

Thanks for the review @VladimirFilonov Have addressed the review comments now 🙌

amritansh22 avatar Oct 07 '24 07:10 amritansh22