lazygit.nvim icon indicating copy to clipboard operation
lazygit.nvim copied to clipboard

Do you think it'd be possible to open the commit editor via nvr in a floating window as well?

Open tjdevries opened this issue 5 years ago • 3 comments

Pretty much title...

Could be cool to open a floating window on top of the lazygit one. Just a thought :) Don't know if it's possible or not.

tjdevries avatar Jul 30 '20 16:07 tjdevries

Yeah, I think it would be technically possible.

I would have to set it up such that

  1. nvm opens the editor in a floating window instead of just calling nvm directly.
  2. the lazygit.nvim's floating window autocmd to close it should be removed in this case where a user would want to do this

I'm curious why you would want that though. If you didn't use nvm, then the commit editor would open within the floating window that lazygit.nvim opens. Is that what you are trying to do?

Or are you trying to have the floating window for the commit editor as well as the floating window for lazygit at the same time? The latter won't be useful unless you use transparency or you can move the floating windows so you see both at the same time.

Does that make sense?

kdheepak avatar Jul 30 '20 18:07 kdheepak

Well I don't like using the embedded nvim inside of the terminal (because sometimes I press esc to the wrong thing or stuff like that). You can ignore the request though, was just wondering if it was possible because I like floating windows. No big reason :laughing:

tjdevries avatar Aug 08 '20 19:08 tjdevries

@tjdevries I was hoping this was possible too. For what it's worth, here is my workaround:

-- Any embedded terminals will use a neovide popup as default editor
vim.env.EDITOR = "neovide --geometry 60x40 --wayland-app-id neovide-floating --nofork -- +startinsert"

Neovide is a Neovim GUI. With this specific incantation, it launches as a floating window at the center of the screen in insert mode, ready to type. Works like a charm.

image

It would be nice if it was possible to do this with a floating window instead, but I suspect that would require a plugin working together with nvr. Probably out of scope for lazygit.nvim.

@kdheepak Presumably the commit editor window would be smaller than the lazygit window, so it's clear that it's on top.

Hubro avatar Aug 10 '21 14:08 Hubro