theseus icon indicating copy to clipboard operation
theseus copied to clipboard
verified publisher icon kaylode

To be A+ rank (or highest) on CodeFactor and beyond

Open kaylode opened this issue 4 years ago • 5 comments

Current rank: CodeFactor

Solve these to unlock this achievement: https://www.codefactor.io/repository/github/kaylode/theseus/issues

kaylode avatar Apr 04 '22 09:04 kaylode

Hi @kaylode. Could you enable the code-factor branch in CodeFactor? It's for solving the issues. Thank you very much!

lannguyen0910 avatar Apr 18 '22 10:04 lannguyen0910

Hi @kaylode. Could you enable the code-factor branch in CodeFactor? It's for solving the issues. Thank you very much!

Ok I've just enabled that

kaylode avatar Apr 18 '22 13:04 kaylode

Current rank: CodeFactor Solve these to unlock this achievement: https://www.codefactor.io/repository/github/kaylode/theseus/issues

  • It seems not possible to achieve higher code quality than A in CodeFactor :))
  • Even if we solve all the issues, it won't improve the quality at all. Maybe it does analyze the packages/dependencies/libraries/frameworks that we imported to the project, i guess, maybe not?
  • The issues are sometimes wrong or not worth solving and might damage the overall code.
  • I recommend you should consider trying out other code analysis services.

lannguyen0910 avatar Apr 18 '22 14:04 lannguyen0910

What do you mean that we can't get higher than A, the highest rank that can be achieved in CodeFactor is A+, according to this. Personally, I think this analysis tool is only for fun only, in fact it doesn't actually improve any the parts of the original code. Thus, if there are some issues that can't be resolved, then maybe we can accept the A score for now :>

kaylode avatar Apr 18 '22 14:04 kaylode

Ah okay :v it was just my guess, i didn't saw the support info. Thanks anyways 😂

lannguyen0910 avatar Apr 18 '22 15:04 lannguyen0910