ember-cli-code-coverage icon indicating copy to clipboard operation
ember-cli-code-coverage copied to clipboard

modifyAssetLocation is not called for paths starting with ".."

Open lfloyd117 opened this issue 1 year ago • 1 comments

Right here ember-cli-code-coverage skips calling modifyAssetLocation if the path starts with .. because it assumes it is correct by manner of being in a monorepo. https://github.com/ember-cli-code-coverage/ember-cli-code-coverage/blob/master/packages/ember-cli-code-coverage/lib/attach-middleware.js#L107-L109

A little bold to assume it is always correct. As I understand it, modifyAssetLocation is an entirely optional configuration so the developer can override the paths if ember-cli-code-coverage doesn't get it quite right. Whether in or out of a monorepo this should be no different. In my case (and the case of others), we need to adjust it and just end up having to do so after tests run via bash script rather than being able to just configure it here.

lfloyd117 avatar Jul 03 '24 19:07 lfloyd117

@lfloyd117 can you say more about your situation? We are running into problems where we have 3 different test runs for 3 different workspaces, all of which test the same file, which means we have 3 coverage outputs for the same file, and I am unsure how to merge them. I am curious if you are changing paths to accomplish something like this?

RobbieTheWagner avatar Aug 14 '24 12:08 RobbieTheWagner