llm.c icon indicating copy to clipboard operation
llm.c copied to clipboard

add http status check for download_file

Open BilyZ98 opened this issue 1 year ago • 1 comments

This pr add http status check for download_file and reports error if it fails to download file. I met a issue that curl does not report error when it failed to pull model from huggingface through proxy and get http error 503 . But the output still is that Downloaded gpt2_124M_bf16.bin to /home/bily/llm.c-fork/dev/../gpt2_124M_bf16.bin despite that it does not downloads the file successfully.

BilyZ98 avatar Jun 25 '24 05:06 BilyZ98

Hi @miro5lav , thanks for review. Do you how this pr can be merged? It looks like it has to go through workflow that can only be triggered by maintainer.

BilyZ98 avatar Jun 26 '24 14:06 BilyZ98