karlch
fix missing PREFIX usages in Makefile
I'm not 100% sure, but I was trying to install vimiv into ~/.local/ and expected vimiv.desktop to end up in ~/.local/share/applications/vimiv.desktop, not ~/.local/usr/share/applications/vimiv.desktop.
I also had to modify the setup line to:
python3 setup.py install --user --record=install_log.txt
Because I couldn't quite figure out the right way to use destdir and prefix to get things into ${HOME}/.local/ (they kept going into ${HOME}/.local/local).
Ermm, okay, I think the line I wanted is something like:
python3 setup.py install --root=$(DESTDIR) --prefix=$(PREFIX) --record=install_log.txt
where DESTDIR is "/home/xxx" and PREFIX is "/.local"
That said, that then conflicts with other things in the file, and would imply that the default "PREFIX" should be /usr/local, not just "/usr" (for Python to install it into /usr/local as per usual).
I also adjusted install_icons.sh to use ${DESTDIR}${PREFIX}
Thanks for catching this! If you like, you could also add your modified install_icons.sh file and for consistency change the python line to the line you proposed:
python3 setup.py install --root=$(DESTDIR) --prefix=$(PREFIX) --record=install_log.txt
As explained in #18 I would prefer not to install to /usr/local as it violates the packaging standards of arch linux which is the system I use. Changing the PREFIX to /usr/local should however have the expected effect which your changes should achieve :smile: Thanks again!
Yes, I'll try to get to it this weekend! I didn't want to submit my subsequent changes yet since I wasn't completely confident in that approach.