BirdNET-Analyzer icon indicating copy to clipboard operation
BirdNET-Analyzer copied to clipboard

Dockerfile.client and Dockerfile.server

Open bdfrost opened this issue 3 years ago • 4 comments

Created new Dockerfiles for a server and a client to assist in having a local dockerized server and local dockerized client.

This would assist those hoping to test or run these without mucking up their Python environment and should give handy examples hoping to extend the environment.

BTW -- I love what y'all have already provided.

bdfrost avatar Apr 20 '22 14:04 bdfrost

Great, thanks for this! Can you please check, there's a duplicate line in the server file ("Install required Python packages -- either librosa or numpy"). Could you also please add a note or quick "How-to" to the README explaining the two files? Thanks!

kahst avatar Apr 21 '22 08:04 kahst

Also, can you please take a look at #16, seems like both PRs have the same goal but slightly different attempts.

kahst avatar Apr 21 '22 08:04 kahst

I cleaned up that bad copy and paste then updated the README to include the client and server. I also reviewed #16 but I didn't integrate that change as it ends up making the dockerfile larger in an attempt to make it single purpose. The dockerfile running just the client.py doesn't need bottle or tensorflow.

I used Dockerfile.server and Dockerfile.client since docker expects a directory to only have one Dockerfile in it. After you build, the specified Dockerfile.X doesn't have any negative impact and the facility is included in docker for situations just like this.

bdfrost avatar Apr 21 '22 14:04 bdfrost

Alright, I think that's ok considering your comments. Would you mind updating the README in a way that the command line arguments only appear once, instead of repeating them for each use case? Also, if you adjust headlines, can you please also adjust shortcut links in the "Contents" section? Thanks.

kahst avatar Apr 25 '22 18:04 kahst

I like the exact versioning, but the split of the Dockerfile makes it overly complicated. We probably just add bottle to the Dockerfile to support server.py as well and take the puny overhead, which this change introduces to the analyzer use with Docker.

tommy4st avatar Feb 22 '23 12:02 tommy4st