phantomgo icon indicating copy to clipboard operation
phantomgo copied to clipboard

Run PhantomJS binary from PATH rather than absolute path

Open tutley opened this issue 9 years ago • 1 comments

I really like this package, but I don't like how it includes the PhantomJS binary. I think this is a great idea though so I want to try and use it in a website. So, I changed the phantomjsPath to simply "phantomjs" meaning it gets executed by searching the environment's PATH variable. I have phantom installed in /usr/local/bin which is a part of my path, but in other machines it might be installed somewhere else, so using the absolute path doesn't make sense. Also, you don't want to have to be responsible for maintaining the PhantomJS library in the repository, or for including a binary for every architecture.

tutley avatar Jan 28 '17 17:01 tutley

thx for your pull request,but i think about the same,so change it when you need .

k4s avatar Feb 09 '17 08:02 k4s