BrowserFS icon indicating copy to clipboard operation
BrowserFS copied to clipboard
verified publisher icon jvilk

Promises API

Open juancampa opened this issue 8 years ago • 3 comments

There's a new (albeit experimental) promise API. I just wanted to create an issue and discuss if it's worth implementing in BrowserFS. Any thoughts?

https://nodejs.org/api/fs.html#fs_fs_promises_api

Thanks for this great module btw.

juancampa avatar Apr 29 '18 20:04 juancampa

Interesting. I think I'd wait for it to become more stable; it would be a lot of churn to keep up with an experimental API.

jvilk avatar May 01 '18 17:05 jvilk

Would you consider accepting a PR for this functionality? I think I could just shim most of the existing functions.

ghost avatar Jan 29 '19 22:01 ghost

Maybe time for this now? :)

dbrock avatar Mar 29 '20 17:03 dbrock

it'd definitely be super useful, currently I have to promisify each of the node fs methods

RiccardoBiosas avatar May 19 '23 04:05 RiccardoBiosas

@RiccardoBiosas I'm currently working on converting the internals to using promises and fixing tests so after that adding a compatibility layer should be very easy.

james-pre avatar May 19 '23 12:05 james-pre

In case your interested @RiccardoBiosas @sixman9 @juancampa @dbrock:

Added in c8b960b

james-pre avatar Sep 23 '23 18:09 james-pre