ods icon indicating copy to clipboard operation
ods copied to clipboard

Adapter preview persistence

Open mathiaszinnen opened this issue 5 years ago • 5 comments

Currently all imported data is persisted in the adapter, even if the result is returned directly and not a reference to the persisted data. I suggest we adapt the /preview and /preview/raw endpoints so that data is always included there and never persisted. Another possibility would be to move the persistence to the stateful datasource package altogether and never persist anything in the adapter package like proposed in #267 . Any opinions @georg-schwarz , @lunedis , @sonallux ?

mathiaszinnen avatar Dec 09 '20 08:12 mathiaszinnen

I like the second idea. We only need to persist data that is part of the internal flows, so it should be part of the datasource domain instead of the stateless adapter domain.

georg-schwarz avatar Dec 09 '20 08:12 georg-schwarz

How does this issue relate to #135 ?

It seems like we should discuss a refactoring and/or redesign of the adapter/datasource service.

lunedis avatar Dec 09 '20 08:12 lunedis

Resembles the last bullet point of #135. I think this issue #283 is the first step to complete the refactoring in #135 afterwards for better paths to the imports.

georg-schwarz avatar Dec 09 '20 09:12 georg-schwarz

It seems like we should discuss a refactoring and/or redesign of the adapter/datasource service.

Agreed, I think both issues are closely related and it probably makes sense to handle both doing a major refactoring..

mathiaszinnen avatar Dec 09 '20 09:12 mathiaszinnen

Duplicate of #267 btw if we handle it like this.

georg-schwarz avatar Dec 09 '20 09:12 georg-schwarz