httpclient-interception icon indicating copy to clipboard operation
httpclient-interception copied to clipboard

Drop Newtonsoft.Json and unsupported TFMs

Open martincostello opened this issue 3 years ago • 1 comments

  • Remove net461 and net5.0 TFMs, as those versions are no longer supported.
  • Add net6.0 TFM.
  • Remove dependency on Newtonsoft.Json and just use System.Text.Json.
  • Update NuGet packages to their latest, or more recent, versions.
  • Add async overload for registering an HTTP bundle.
  • Remove redundant cast needed from net5.0 TFM.

Resolves #441. Resolves #442.

martincostello avatar May 14 '22 14:05 martincostello

Codecov Report

Merging #444 (c8a5646) into main (0cbb0b0) will decrease coverage by 0.14%. The diff coverage is 95.45%.

:exclamation: Current head c8a5646 differs from pull request most recent head bf6b9ea. Consider uploading reports for the commit bf6b9ea to get more accurate results

@@             Coverage Diff             @@
##              main     #444      +/-   ##
===========================================
- Coverage   100.00%   99.85%   -0.15%     
===========================================
  Files           16       15       -1     
  Lines          704      705       +1     
===========================================
  Hits           704      704              
- Misses           0        1       +1     
Flag Coverage Δ
linux 99.85% <95.45%> (-0.15%) :arrow_down:
macos 99.85% <95.45%> (-0.15%) :arrow_down:
windows 99.85% <95.45%> (-0.15%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HttpClientInterception/Bundles/Bundle.cs 100.00% <ø> (ø)
src/HttpClientInterception/BundleExtensions.cs 96.66% <90.90%> (-3.34%) :arrow_down:
...rc/HttpClientInterception/Bundles/BundleFactory.cs 100.00% <100.00%> (ø)
src/HttpClientInterception/Bundles/BundleItem.cs 100.00% <100.00%> (ø)
...pClientInterception/Bundles/BundleItemConverter.cs 100.00% <100.00%> (ø)
...rception/HttpClientInterceptorOptionsExtensions.cs 100.00% <100.00%> (ø)
...eption/HttpRequestInterceptionBuilderExtensions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de1e9c6...bf6b9ea. Read the comment docs.

codecov-commenter avatar May 14 '22 14:05 codecov-commenter