superposition icon indicating copy to clipboard operation
superposition copied to clipboard

feat: wrapper connection implementation

Open ShubhranshuSanjeev opened this issue 1 year ago • 3 comments

Problem

Describe the problem you are trying to solve here

Solution

Provide a brief summary of your solution so that reviewers can understand your code

Environment variable changes

What ENVs need to be added or changed

Pre-deployment activity

Things needed to be done before deploying this change (if any)

Post-deployment activity

Things needed to be done after deploying this change (if any)

API changes

Endpoint Method Request body Response Body
API GET/POST, etc request response

Possible Issues in the future

Describe any possible issues that could occur because of this change

ShubhranshuSanjeev avatar Jan 31 '25 14:01 ShubhranshuSanjeev

A couple of things.

  1. What is happening to the prepared statement objects in postgres? Are we creating them everytime? And if so are they being GC'd?
  2. How are we planning to handle schema changes during the execution of flow? For instance, during workspace setup we want to first create the workspace schema, ran from inside the public schema & then switch to the superposition schema for inserting into the workspaces table, all in one transaction.
  3. Can we please add the debug logs for each query based on an env as well? That would be a very useful thing to have.
  4. Can you add tests that verify that things are working as intended?

ShreyBana avatar Jan 31 '25 15:01 ShreyBana

I am seeing that we don't need the .schema(..) DSL w/ this, we might just be able to move back to standard diesel!

ShreyBana avatar Jan 31 '25 15:01 ShreyBana

... 4. Can you add tests that verify that things are working as intended?

I can do the tests part if something is taking time.

ShreyBana avatar Jan 31 '25 16:01 ShreyBana