nbgitpuller icon indicating copy to clipboard operation
nbgitpuller copied to clipboard
verified publisher icon jupyterhub

nbgitpuller chrome extension not working when pulling branches other than main

Open rohanjha123 opened this issue 3 years ago • 6 comments

The nbgitpuller doesn't generate the right link when pulling branches other than main. When I tried pulling this file to data100.datahub.berkeley.edu using the chrome extension, the load failed. However, when I manually input all the info here and tried again, the pull succeeded, causing me to believe it's an issue with the chrome extension. A photo of the manual input can be seen below. Screen Shot 2023-01-29 at 11 21 46 AM

Expected behaviour

The link loads properly

Actual behaviour

The chrome extension file redirect doesn't load properly. Instead, the following error message pops up Screen Shot 2023-01-29 at 11 16 27 AM

How to reproduce

Use the chrome extension to generate a nbgitpuller link for this file

Your personal set up

  • OS: macOS 11.3.1
  • Version(s): nbgitpuller 1.1.0, jupyterhub 3.1.0, notebook==6.4.12, jupyterlab==3.4.5, python==3.9
Full environment

The full environment can be found here and here.

Configuration 
# jupyterhub_config.py
Logs

rohanjha123 avatar Jan 29 '23 19:01 rohanjha123

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Jan 29 '23 19:01 welcome[bot]

@yuvipanda FYI!

balajialg avatar Jan 30 '23 18:01 balajialg

Friendly reminder @yuvipanda! Fixing this issue will be very helpful for the data 100 testing workflow

rohanjha123 avatar Apr 03 '23 23:04 rohanjha123

Hi @balajialg and @rohanjha123! Unfortunately I don't think I have time to look into this right now :( However, if you can make a PR to the repo (which is at https://github.com/yuvipanda/nbgitpuller-link-generator-webextension), I can take a look. Otherwise it might be a while before I can look at this.

yuvipanda avatar Apr 07 '23 09:04 yuvipanda

@yuvipanda Thanks. I will sync up with @rohanjha123 to figure out ways to create PR to this repo.

balajialg avatar Apr 07 '23 21:04 balajialg

@rohanjha123 @balajialg - i am gonna make a comment on Webextension where you should be able to make the PR

https://github.com/yuvipanda/nbgitpuller-link-generator-webextension/issues/1

ericvd-ucb avatar May 10 '23 23:05 ericvd-ucb