lsp-setup.nvim icon indicating copy to clipboard operation
lsp-setup.nvim copied to clipboard
verified publisher icon junnplus

Broken on windows

Open mg-bayoo opened this issue 3 years ago • 4 comments

Hi, since you moved the module to nvim-lsp-setup, the package is broken on windows, because it cannot link to the lsp-setup directory, and the init.lua requires lsp-setup.utils

mg-bayoo avatar Aug 24 '22 14:08 mg-bayoo

Don't you have it backwards? cdb09707ae768f97f13ae12c8b7ba9f13c044654 nvim-lsp-setup => lsp-setup.nvim

soupersauce avatar Aug 26 '22 02:08 soupersauce

It doesn't matter under windows which turn around it is, since the link of lsp-setup to the old nvim-lsp-setup does not work on windows (it shows up as an file with the content ./nvim-lsp-setup), the call local utils = require('lsp-setup.utils') fails. So the better fix would probably to rename the directory nvim-lsp-setup to lsp-setup and to add a link named nvim-lsp-setup besides.

This would potentially break configs for windows users (which still use require('nvim-lsp-setup'), but this could then easily be fixed in the config.

mg-bayoo avatar Aug 26 '22 05:08 mg-bayoo

Nevermind. I see your point now. Didn't realize the problem was due to a symlink.

soupersauce avatar Aug 26 '22 06:08 soupersauce

@mg-bayoo Sorry for the late reply, I will take the time to fix it soon, PRs are welcome too

junnplus avatar Aug 26 '22 16:08 junnplus

Same here. My current work around is to rename the folder nvim-lsp-setup to lsp-setup and remove sync link in the installed package.

TisnKu avatar Sep 23 '22 03:09 TisnKu