MathOptInterface.jl icon indicating copy to clipboard operation
MathOptInterface.jl copied to clipboard

Add Variable bridges to use runtests without unbridged_variable

Open blegat opened this issue 1 year ago • 3 comments

Some variable bridges don't support unbridged_variable and that makes runtests fail when getting ConstraintFunction or when getting ConstraintSet for scalar constraints. For example, ZerosBridge does not support it so it cannot use runtests. Another example is the SOS cone: https://github.com/jump-dev/SumOfSquares.jl/pull/353 I could support it in the nonweighted version but if it's weighted by arbitrary polynomials, it seems difficult to unbridge. It might be possible but it's not high priority. By using only vector cones in the tests, it turns out that only this small change is enough to pass the tests. This is still testing the inner model completely.

  • [ ] Explain in docstring why this is used for
  • [ ] Use it for ZerosBridge by adding a tests without scalar sets

blegat avatar May 10 '24 07:05 blegat

Did you try ZerosBridge? It still failed in a bunch of places

odow avatar May 12 '24 21:05 odow

I did not try, I was just hoping it could serve as a test

blegat avatar May 13 '24 06:05 blegat

The issue is that a bunch of other places may call ConstraintFunction, so it is not so simple

odow avatar May 13 '24 21:05 odow

I don't think this is the right approach. Just write some other tests. You don't need general infrastructure.

odow avatar Jun 21 '24 23:06 odow

What about now ?

blegat avatar Jun 25 '24 14:06 blegat