nodebb-plugin-session-sharing icon indicating copy to clipboard operation
nodebb-plugin-session-sharing copied to clipboard
verified publisher icon julianlam

Could this be async.each?

Open uplift opened this issue 4 years ago • 2 comments

Following on from https://github.com/NodeBB/NodeBB/issues/10410 could this upgrade use async.each instead of async.eachSeries. Is order important in this script? As far as I can tell it isn't but I'm not 100%.

https://github.com/julianlam/nodebb-plugin-session-sharing/blob/dacbc752b22bf00b7343d060c1a11b4137d69296/upgrades/session_sharing_hash_to_zset.js#L51-L54

uplift avatar Mar 18 '22 15:03 uplift

Good lord this upgrade script is old.

If you still do need it, then it'd be best to have this one rewritten in async..await, but looking at that code, it should be fine to just change it to async.each.

julianlam avatar Apr 26 '22 18:04 julianlam

Yeah I ended up rewriting it as async await in the end.

uplift avatar Apr 27 '22 16:04 uplift