Joseph Watson
Joseph Watson
I removed the methods `browser.SetMaxHistory()` and `browser.ClearHistory()`. I also exposed 4 jar objects so they can be manipulated directly.
Done. We now have the same methods as part of the `Browsable` interface.
The last item that I would like to do is change the default history length to 100. What is the procedure to make this in a patch release?
I just added a PR to change the default.
This should work: ``` b := surf.NewBrowser() b.HistoryJar().SetMax(1) ```
The PR was merged into the master branch, but has not been released with a version tag... Checkout master and you should be seeing the new Methods.
@dhui This PR supersedes the following PR #733, #910, #924 It is a robust implementation that greatly improves support for Spanner migrations. It also fixes a lot of open issues...
@dhui Can you take a look at this PR, please? The community will benefit from it.
@dhui Will you please take a look at this PR? It has been well tested and is in production use, so would be nice to get it merged!
@dhui Rebased onto master branch and all tests look good. I would love to get a review on this!