typebox-validators icon indicating copy to clipboard operation
typebox-validators copied to clipboard

Unable to install due to not up to date deps

Open wdanilo opened this issue 2 years ago • 3 comments

When running npm install typebox-validators, npm tells me that it cannot resolve dependency @sinclair/typebox, as my project uses @sinclair/typebox@"0.32.13" and this requires @sinclair/typebox@"^0.30.4".

wdanilo avatar Feb 09 '24 14:02 wdanilo

Oh dear. I upgraded to typebox 0.32.x, and now some tests fail. It looks like typebox made some change that is incompatible with typebox-validators customer error messages.

jtlapp avatar Feb 11 '24 16:02 jtlapp

same problem here; are you planning to update that, or not yet planned ? :) and thanks for the lib

rvion avatar Mar 25 '24 14:03 rvion

I'm not planning to revise the code, but I welcome a PR.

This will be the second time the code had to be revised to support a change in TypeBox, and this time it's not clear to me that I'll be able to retain existing functionality.

I get the feeling that it's better to move the functionality into TypeBox proper, so there will be effort not to break it on each revision.

jtlapp avatar Mar 25 '24 23:03 jtlapp