spin icon indicating copy to clipboard operation
spin copied to clipboard

Added Padrino support by default

Open Who828 opened this issue 12 years ago • 7 comments

Hey,

I just added a ENV variable and a default preload path to make it work with Padrino out of the box.

Thank you making this gem, It was so simple to port it :)

Who828 avatar Nov 17 '13 14:11 Who828

Thanks! Could you also add a changelog entry and mention the Padrino support in README?

kirs avatar Nov 17 '13 14:11 kirs

I changed the README, changelog and the version. (did you want me to change the version?) Let me know if there anything more to be done.

Regards

Who828 avatar Nov 17 '13 14:11 Who828

Thanks! Could you also revert the lib/spin/version.rb?

kirs avatar Nov 17 '13 14:11 kirs

Done!

Who828 avatar Nov 17 '13 14:11 Who828

I don't think it's the best strategy to define "if there is no config/application.rb, then app is Padrino-based". Is there any Padrino-specific file?

kirs avatar Nov 17 '13 15:11 kirs

I checked and I couldn't find any padrino specific file. We can also check the Gemfile (see if it has Padrino or not) but that might increase the complexity and it might not always be correct.

For example there might be a mountable gem, which has dependency on Padrino and the core app is Rails or vice versa. (though if its a dependency then it won't appear in the Gemfile, it will be in the Gemfile.lock)

I am leaning more towards just giving an option to the user (--padrino), so we don't have to break our heads to determine if its Padrino app or not.

Who828 avatar Nov 17 '13 16:11 Who828

Maybe you can use if defined?(Padrino)

parasnarang avatar Jan 29 '16 05:01 parasnarang