website icon indicating copy to clipboard operation
website copied to clipboard

[pages][tools]: Implement Tooling Analytics and Integrate Bowtie Report

Open DarhkVoyd opened this issue 1 year ago • 15 comments

What kind of change does this PR introduce? This PR aims to provide some bug fixes, clean code refactor, enhanced code and add new enhancements such as implementation of analytics for tooling trends for the tooling page and integrate bowtie report in the current design.

Issue Number:

  • Closes #778 #780
  • Related to: #716
  • Others?

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

DarhkVoyd avatar Aug 12 '24 12:08 DarhkVoyd

I would also like a chance to review this from a UX perspective. I'm curious how the Bowtie integration looks.

Still waiting for a good build so that a preview is generated.

gregsdennis avatar Aug 15 '24 12:08 gregsdennis

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (05d16e9) to head (39b73e4). Report is 6 commits behind head on web-release-tooling.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           web-release-tooling      #858   +/-   ##
=====================================================
  Coverage               100.00%   100.00%           
=====================================================
  Files                        1         1           
  Lines                       20        20           
  Branches                    12        12           
=====================================================
  Hits                        20        20           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 17 '24 09:08 codecov[bot]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 39b73e42b4d7a49bb5683a749161726711df1df6

github-actions[bot] avatar Aug 17 '24 09:08 github-actions[bot]

@benjagm Thanks! I have rebased the PR with latest changes, fixed conflicts and linting issues. The preview is not working as expected as the redirects takes us back to the previous implementations page, should I go ahead and remove it?

DarhkVoyd avatar Aug 17 '24 09:08 DarhkVoyd

@benjagm Thanks! I have rebased the PR with latest changes, fixed conflicts and linting issues. The preview is not working as expected as the redirects take us back to the previous implementations page, should I go ahead and remove it?

Yes, We'll need to replace the old redirect available in the _redirects file: Now we have: /tools /implementations 301

We should replace it by: /implementations /tools 301

benjagm avatar Aug 17 '24 09:08 benjagm

Now, we just need to add the backend API to complete the integration.

DarhkVoyd avatar Aug 17 '24 09:08 DarhkVoyd

Still waiting for a good build so that a preview is generated.

Now we have the preview here: https://github.com/json-schema-org/website/pull/858#issuecomment-2294805144

benjagm avatar Aug 17 '24 09:08 benjagm

Now, we just need to add the backend API to complete the integration.

Let's do it!

benjagm avatar Aug 17 '24 09:08 benjagm

I think we also need update the main nav link to /tools. Next router might not use the Cloudflare redirects.

DarhkVoyd avatar Aug 17 '24 09:08 DarhkVoyd

I think we also need update the main nav link to /tools. Next router might not use the Cloudflare redirects.

Yes. Better to change that link. You can also perform a search in the codebase looking for internal links pointing to "/implementations" because I am sure there will be some more.

benjagm avatar Aug 17 '24 09:08 benjagm

What page is the change on? The preview link just takes me to the home page.

(We should probably ask this in the PR template.)

gregsdennis avatar Aug 17 '24 10:08 gregsdennis

@gregsdennis I was just updating redirects and internal links, you can now easily preview changes on the tooling page after the new preview build.

DarhkVoyd avatar Aug 17 '24 10:08 DarhkVoyd

Is this Bowtie "integration" just a link to the Bowtie site? From the description, I thought it'd be more.

gregsdennis avatar Aug 17 '24 10:08 gregsdennis

@gregsdennis to utilise the space on the tooling table most optimally the tooling table has a outlink to bowtie for anyone interested, If you click on any tool it will display the tool with detailed information including bowie report and compliance in an information modal.

DarhkVoyd avatar Aug 17 '24 10:08 DarhkVoyd

Is this Bowtie "integration" just a link to the Bowtie site? From the description, I thought it'd be more.

When you click over a tool, you see the details in a pop-up and when that tool is integrated with Bowtie you'll see all the badges.

benjagm avatar Aug 19 '24 07:08 benjagm