website icon indicating copy to clipboard operation
website copied to clipboard

I updated the base URI and included a Draft-specific info box section

Open Dule-martins opened this issue 1 year ago • 2 comments

$ids were changed to absolute URIs. A Draft-specific Info block that supports changing dialects in an embedded schema (using $schema with a different value than the parent schema) with an explanation of the difference between 2020-09 and 2020-12

What kind of change does this PR introduce? refactoring doc

Issue Number:

  • Closes #647

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Dule-martins avatar Apr 22 '24 17:04 Dule-martins

Hi @Dule-martins . We are almost done with the changes to merge this PR. Can you please review the last comments?

benjagm avatar May 16 '24 12:05 benjagm

I will do that later tonight, after work thank you On Thu, 16 May 2024 at 13:33, Benjamin Granados @.***> wrote:

Hi @Dule-martins https://github.com/Dule-martins . We are almost done with the changes to merge this PR. Can you please review the last comments?

— Reply to this email directly, view it on GitHub https://github.com/json-schema-org/website/pull/673#issuecomment-2115129985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH4ASUU3GMHYXK2KZUWJUGDZCSRQHAVCNFSM6AAAAABGTF7LU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGEZDSOJYGU . You are receiving this because you were mentioned.Message ID: @.***>

Dule-martins avatar May 16 '24 17:05 Dule-martins

Hello! :wave:

This pull request has been automatically marked as stale due to inactivity :sleeping:

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific pull request has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this pull request forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience :heart:

github-actions[bot] avatar Jun 16 '24 00:06 github-actions[bot]

Hi @Dule-martins . We are almost done with the changes to merge this PR. Can you please review the last comments?

Hey @benjagm my apologies it took me longer than I thought before returning to this PR! I removed the two lines of sentences that were highlighted by @jdesrosiers

Dule-martins avatar Jun 25 '24 14:06 Dule-martins

Congratulations, @Dule-martins for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

github-actions[bot] avatar Jun 26 '24 17:06 github-actions[bot]

Thanks for making this happen :clap:

jdesrosiers avatar Jun 26 '24 17:06 jdesrosiers

Thanks for making this happen 👏

Your guidance saw me through. Thanks and would love to more if possible

Dule-martins avatar Jun 26 '24 18:06 Dule-martins