phpWhois
phpWhois copied to clipboard
Throw an exception when trying an unsupported TLD
Throw an exception when trying an unsupported TLD, instead of returning empty data.
While I don't have a problem with this change (I quite like it, in fact), it is a backwards compatibility break and minimally needs to be documented with @throws. I think it also wise to start a running list of changes in the CHANGELOG.md file under a new 6.0.0-alpha1 heading and Backwards Compatibility Breaks sub-heading.
I would also like to see a test case verifying that the correct exception is thrown.