phpWhois icon indicating copy to clipboard operation
phpWhois copied to clipboard

Throw an exception when trying an unsupported TLD

Open tomsommer opened this issue 7 years ago • 1 comments

Throw an exception when trying an unsupported TLD, instead of returning empty data.

tomsommer avatar Sep 13 '18 11:09 tomsommer

While I don't have a problem with this change (I quite like it, in fact), it is a backwards compatibility break and minimally needs to be documented with @throws. I think it also wise to start a running list of changes in the CHANGELOG.md file under a new 6.0.0-alpha1 heading and Backwards Compatibility Breaks sub-heading.

I would also like to see a test case verifying that the correct exception is thrown.

jsmitty12 avatar Sep 28 '18 12:09 jsmitty12