jsa34
jsa34
Addressed feedback :)
@youtux tried rerunning the checks, but codecov consistently seems unhappy. Not sure what's happening...
This is just my first draft where I made sure that everything "works". If/once the approach is agreed, I will still need to do tests, documentation, etc., but I thought...
> > ♻️ Anything particular you want feedback on? > > Approach, public API changes, format of the named args, whether it's acceptable in general! > > I wasn't aware...
> One thing I wanted to ask is whether you'd want to get both named for param types and regex out simultaneously or whether you'd want / consider doing them...
Thanks for the PR! Could you add tests for this?
I have a feeling this is related to my workaround when I implemented gherkin from cucumber for compatibility, but changing it would be a breaking change for how it used...
> maybe we should change `gherkin-official` to return classes instead of dicts now. WDYT? Good point - ideally, I guess it should return the gherkin messages format (which will be...
This is currently blocked until such time as either named parameters can be returned by Cucumber Expressions, or a suitable solution that adheres to the current syntax expected for pytest-bdd...
This is currently blocked until Cucumber provides a messages implementation in Python. There's currently a PR open but not resolved: https://github.com/cucumber/messages/pull/165