jrobind
Convert CSS to SASS/SCSS – vanilla app
It would be nice to refactor our styles so they are more maintainable and reusable. A few considerations for this:
- Introduce a naming convention such as BEM
- Organise styles into components
- Utilise SASS features such as mixins, imports, variables, maps etc
We've recently added Gulp but it might make more sense to use Webpack and let it handle code minification, asset optimisation and SASS to CSS compilation.
These are just some ideas and suggestions – this is open for discussion 😄
Hey @muzamil301, I'd recommend just working on one ticket at a time for now 😄
I guess it's more appropriate to continue here. So I will do this for the vanilla part.
Hi have been working on this issue but I have a problem. When I open the index.html file in the public folder of the main-app I get this
Have I screwed something?
I cloned it again from fresh in another local dir but still the same
Yeah you can proceed with it.
On Sun, 8 Aug 2021 at 11:14 akashpatil14298 @.***> wrote:
Hi @jrobind https://github.com/jrobind , If this issue is open, I would like to work on it..
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jrobind/dev-jot/issues/113#issuecomment-894774632, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY4OZKQFAYWC4FF4HRJJLLT3ZKINANCNFSM42RNDY2Q .
Yes, it is.
On Tue, 14 Sep 2021 at 19:06 Priyang @.***> wrote:
is issue still open???
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jrobind/dev-jot/issues/113#issuecomment-919392701, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY4OZPJKTBMRIJ4VDQ7QU3UB6FMFANCNFSM42RNDY2Q .