django-structlog icon indicating copy to clipboard operation
django-structlog copied to clipboard

[proposal] run tests only with supported django and python versions

Open jairhenrique opened this issue 3 years ago • 3 comments

This test matrix proposal is based on https://endoflife.date/django

jairhenrique avatar Aug 05 '22 20:08 jairhenrique

Codecov Report

Merging #110 (bd8a954) into master (8e941fe) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1209      1209           
=========================================
  Hits          1209      1209           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 21:08 codecov[bot]

Since the beginning of the project I had this in mind:

  1. keep the compatibility until there are breaking changes (Ex: threadlocal vs contextvars) or the maintainability is unbearable (Ex: I kept python 3.4 for a long time)
  2. drop support with documented incompatibility in a notable release

Does that sound ok to you?

I am open to discussion.

jrobichaud avatar Aug 09 '22 12:08 jrobichaud

@jrobichaud makes senses, but why support libraries and versions of python who doesn't have support anymore?

I think removing support for these versions encourages and force the community to keep their environment up to date.

jairhenrique avatar Aug 15 '22 17:08 jairhenrique