django-sass-processor icon indicating copy to clipboard operation
django-sass-processor copied to clipboard
verified publisher icon jrief

Broken in Django 5.1 alpha due to get_storage_class

Open washeck opened this issue 2 years ago • 3 comments

Version 1.3 claims Remove usage of deprecated get_storage_class for Django >= 4.2.*. but the fix is only partial.

The deprecated function is not used but it is imported on top of storage.py. Django 5.1 (in development now) removed this deprecated function making django-sass-processor fail with ImportError. The proper fix is to move the import line after the if for django version.

washeck avatar Dec 08 '23 14:12 washeck

@jrief Thanks for merging https://github.com/jrief/django-sass-processor/pull/180

May I ask you to issue a new release with the fix? It would make my life a bit easier with testing our project for compatibility with the upcoming Django release.

washeck avatar May 13 '24 11:05 washeck

What would you like me to add to the Changelog?

jrief avatar May 13 '24 12:05 jrief

I think "Fix compatibility with Django 5.1dev" would be enough

washeck avatar May 15 '24 09:05 washeck

Shall I prepare PR for the changelog entry? Now, when Django 5.1 alpha was released, the issue will become more visible.

washeck avatar May 28 '24 07:05 washeck

Version 1.4.1 has been published: https://pypi.org/project/django-sass-processor/

jrief avatar May 29 '24 14:05 jrief