api.jquery.com icon indicating copy to clipboard operation
api.jquery.com copied to clipboard

Added .editorconfig file

Open AurelioDeRosa opened this issue 9 years ago • 6 comments

.editorconfig file taken directly from jQuery's repository.

AurelioDeRosa avatar Jan 23 '16 17:01 AurelioDeRosa

It's kinda silly to do a direct copy from a different project with different types of files and a different directory structure. Half of these rules are for files that don't even exist, and the majority of the files in this repo don't even get indentation rules applied to them.

scottgonzalez avatar Jan 23 '16 17:01 scottgonzalez

For the benefit of solving this issue, it'd be great if you could point on specific lines that you'd like to change/add/remove. By doing so, we can have a change that works for everyone and improve the status quo. In its current state your comment doesn't really help.

AurelioDeRosa avatar Jan 23 '16 18:01 AurelioDeRosa

@AurelioDeRosa: why bother specifying [**/.js], [**.xml], etc.? Is there a type of file in which we don't use indent_style = tab? I think having one indent_style = tab along with the other rules should be sufficient. Or am I missing something?

kswedberg avatar Jan 23 '16 20:01 kswedberg

I think having one indent_style = tab along with the other rules should be sufficient. Or am I missing something?

Right, almost everything is tab indented, so having that be the default would make sense. package.json and *.yml should be set to two spaces though.

scottgonzalez avatar Jan 23 '16 20:01 scottgonzalez

@AurelioDeRosa It seems to me that current version of Core's .editorconfig would be a good fit, the only modification needed is to apply 2 spaces to *.yml files as well as @scottgonzalez indicated.

Would you like to do it? If not, I'd close this PR and I can do it separately.

mgol avatar Mar 22 '17 21:03 mgol

@AurelioDeRosa ping

mgol avatar Aug 01 '18 12:08 mgol