api.jquery.com icon indicating copy to clipboard operation
api.jquery.com copied to clipboard

Updated cache:true instructions for $.getScript

Open oriadam opened this issue 8 years ago • 3 comments

$.getScript signature of passing a settings object instead of URL string was added on jQuery 1.12. Added the signature to documentation and updated the related workarounds and examples to include the new signature. The example with loading jquery-color was edited to support caching, as caching is highly recommended when loading a plugin.

oriadam avatar Jul 05 '17 15:07 oriadam

Hi @oriadam, thank you for your contribution. Could you update the examples in your PR to match our style guide? You can find the guide here: https://contribute.jquery.org/style-guide/js/

AurelioDeRosa avatar Jan 30 '18 01:01 AurelioDeRosa

Hi @AurelioDeRosa be glad to :) is it ok now ?

oriadam avatar Feb 10 '18 18:02 oriadam

We don't seem to have a style guide for XML documents. The one that @AurelioDeRosa links to describes only JS. We have an HTML doc but our XML files aren't really close to that.

@oriadam I think all XML files should be aligned with each other so they should all use 2-space indentation.

mgol avatar Aug 01 '18 12:08 mgol