additional date german

[ltdeta]

adopted from additional dateITA

[staabm]

Thx for the PR. Please add tests

[stale[bot]]

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)

[ltdeta]

Thx for the PR. Please add tests

What does it actually mean ?

[Arkni]

Hi @ltdeta,

It means you need to add some test for the new method, like it's done with dateITA in https://github.com/jquery-validation/jquery-validation/blob/934822bb1ec52dac0c3de86010e0e69e4b4a2e0f/test/methods.js#L877-L884

[ltdeta]

Here are some tests for the new method

QUnit.test( "dateGER", function( assert ) {
	var method = methodTest( "dateGER" );
	assert.ok( method( "01.01.1900" ), "Valid date GER" );
	assert.ok( method( "17.10.2010" ), "Valid date GER" );
	assert.ok( method( "17.6.1878" ), "Valid date GER" );
	assert.ok( method( "2.6.1870" ), "Valid date GER" );
		
	assert.ok( !method( "01.13.1990" ), "Invalid date GER" );
	assert.ok( !method( "32.05.1990" ), "Invalid date GER" );	
	assert.ok( !method( "00.01.1900" ), "Invalid date GER" );
	assert.ok( !method( "01.02.199" ), "Invalid date GER" );
        assert.ok( !method( "01.02.99" ), "Invalid date GER" );	
	assert.ok( !method( "00.00.1900" ), "Invalid date GER" );
	assert.ok( !method( "0.00.1900" ), "Invalid date GER" );
	assert.ok( !method( "0.0.1900" ), "Invalid date GER" );
} );

[Arkni]

HI @ltdeta,

Sorry for taking so long to respond to you comment. Can you please add those tests after https://github.com/jquery-validation/jquery-validation/blob/934822bb1ec52dac0c3de86010e0e69e4b4a2e0f/test/methods.js#L877-L884 and push the changes.

After that I will merge the PR.

Thanks!