Local files support

Open BitesizedLion opened this issue 4 years ago • 4 comments

Currently breaks if you click into a Playlist that has local files added.

Error: Failed to read JSON: invalid type: null, expected a string at line 263 column 19

Aug 17 '21 12:08 BitesizedLion

Thanks for the report. In the beginning we'll probably just omit the local tracks, but it should definitely load the rest of the playlist.

Aug 18 '21 07:08 jpochyla

We now skip the local files since 967c077, marking as enhancement, since we might support the actual playback in the future.

Aug 18 '21 17:08 jpochyla

Loading a playlist with local files still gave the error when I tried it. It looks like the error is coming from serde/serde_json which can't resolve AlbumLinks because local files return the ID and several more fields as null, which goes unhandled during deserialization. I'll submit a pull request with a fix soon. I got it working on my fork, but it's pretty dirty.

Aug 20 '21 07:08 Shel-M

@AbirV there was indeed another bug, but it should be fixed since yesterday's commit bbca2bca206596fafc2bb180676140ac2ee07500.

Aug 20 '21 08:08 jpochyla